Martin Peřina has posted comments on this change.

Change subject: tools: Adds notifier config validation prior to service startup
......................................................................


Patch Set 4:

(1 comment)

....................................................
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
Line 212:         if proc.returncode != 0:
Line 213:             if stderr:
Line 214:                 stderr = stderr.decode('utf-8', 'replace').rstrip()
Line 215:             raise RuntimeError(stderr)
Line 216: 
Done
Line 217: 
Line 218: if __name__ == '__main__':
Line 219:     service.setupLogger()
Line 220:     d = Daemon()


-- 
To view, visit http://gerrit.ovirt.org/22629
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11ad77a33697f254e60e1d0b12e343900e5b0b34
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to