Alon Bar-Lev has posted comments on this change.
Change subject: tools: Adds notifier config validation prior to service startup
......................................................................
Patch Set 2:
(1 comment)
....................................................
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
Line 195: self.logger.debug('Executing: %s', args)
Line 196: proc = subprocess.Popen(
Line 197: args=args,
Line 198: executable=self._executable,
Line 199: env=self._engineEnv,
as best practice better to do this.
however, maybe worth considering to print validation errors to stderr so they
will be visible at sysv start and systemd journal.
Line 200: )
Line 201:
Line 202: proc.wait()
Line 203:
--
To view, visit http://gerrit.ovirt.org/22629
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11ad77a33697f254e60e1d0b12e343900e5b0b34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
