Ori Liel has posted comments on this change.
Change subject: engine: Enable runOnce to choose a vnc keymap.
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
Line 496: }
Line 497: }
Line 498: if (vm.getDisplay().isSetKeyboardLayout()) {
Line 499: String vncKeyboardLayout =
vm.getDisplay().getKeyboardLayout();
Line 500: if (vncKeyboardLayout != null) {
no need for this check, .isSetKeyboradLayout() does exactly that.
Other than that, +1 for restapi
Line 501: params.setVncKeyboardLayout(vncKeyboardLayout);
Line 502: }
Line 503: }
Line 504: }
--
To view, visit http://gerrit.ovirt.org/22620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id908cbaca9f1b20b4b9868a87a8b21f318a493e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
