Roy Golan has posted comments on this change.
Change subject: engine: Enable runOnce to choose a vnc keymap.
......................................................................
Patch Set 3:
(1 comment)
instead of changing the VM getter and adding one in different name just use
getVm().getDynamicData().getVncKeyboardLayout()
this should actually be the same for all of our static and dynamic equivalents.
less changes and usage of the today encapsulation of the VmDynamic getter under
VM
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 125: if (getParameters().getVncKeyboardLayout() == null) {
Line 126:
getVm().setVncKeyboardLayout(getVm().getDefaultVncKeyboardLayout());
Line 127: } else {
Line 128: // if is not null it means runVM was launch from the run
once command, thus
Line 129: // the VM can run with keyboard layout type which is
different from its default display type
the comment is a bit confusing? did you mean that if its not null than the user
specified it in the runonce ui. by the way, when invoked from REST you should
always expect to see this filled. REST is taking copying all the VM from DB
exept for those you filled - look at VmMapper under restapi/types
Line 130:
getVm().setVncKeyboardLayout(getParameters().getVncKeyboardLayout());
Line 131: }
Line 132: }
Line 133:
--
To view, visit http://gerrit.ovirt.org/22620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id908cbaca9f1b20b4b9868a87a8b21f318a493e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
