Mike Kolesnik has posted comments on this change.

Change subject: webadmin: Ability to add external subnet
......................................................................


Patch Set 3:

(2 comments)

....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ExternalSubnetPopupView.java
Line 49:     @WithElementId("ipVersion")
Line 50:     ListModelListBoxEditor<IpVersion> ipVersionEditor;
Line 51: 
Line 52:     @UiField
Line 53:     @Ignore
Indeed @Path didn't work and this is the way I saw it done in other usages..
Line 54:     StringEntityModelLabelEditor networkEditor;
Line 55: 
Line 56:     private final Driver driver = GWT.create(Driver.class);
Line 57: 


Line 80:     @Override
Line 81:     public void edit(final NewExternalSubnetModel subnet) {
Line 82:         driver.edit(subnet);
Line 83: 
Line 84:         if (subnet.getNetwork().getEntity() != null){
Done
Line 85:             
networkEditor.asValueBox().setValue(subnet.getNetwork().getEntity().getName());
Line 86:         }
Line 87:     }
Line 88: 


-- 
To view, visit http://gerrit.ovirt.org/22689
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7315f9ffe29f72d06deb56dcd637c53fba47b116
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to