Lior Vernia has posted comments on this change.
Change subject: webadmin: Ability to add external subnet
......................................................................
Patch Set 2:
(2 comments)
A little more work to be done probably, please see and reply to comments on
both patch sets.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NewExternalSubnetModel.java
Line 42:
getIpVersion().setItems(AsyncDataProvider.getExternalSubnetIpVerionList());
Line 43:
Line 44: getNetwork().setItems(Arrays.asList(network));
Line 45: getNetwork().setSelectedItem(network);
Line 46: getNetwork().setIsChangable(false);
If the widget is turned into a label and the member to an EntityModel, these
lines should be replaced by setEntity().
Line 47:
Line 48: setHashName("new_external_subnet"); //$NON-NLS-1$
Line 49:
Line 50: initCommands();
Line 145: }
Line 146: }
Line 147:
Line 148: public boolean validate() {
Line 149: getName().validateEntity(new IValidation[] { new
NotEmptyValidation(), new AsciiNameValidation() });
The name validity checks could possibly be removed if the widget is a
non-editable label.
Line 150: getCidr().validateEntity(new IValidation[] { new
NotEmptyValidation() });
Line 151: getIpVersion().validateSelectedItem(new IValidation[] { new
NotEmptyValidation() });
Line 152:
Line 153: return getName().getIsValid() && getCidr().getIsValid() &&
getIpVersion().getIsValid();
--
To view, visit http://gerrit.ovirt.org/22689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7315f9ffe29f72d06deb56dcd637c53fba47b116
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
