Eli Mesika has uploaded a new change for review.

Change subject: Fixing a bug in Alert logging.
......................................................................

Fixing a bug in Alert logging.

Log Alert when failing to get Host status via the PM agent was recorded
to the database without the Host UUID, therefor the attempt to remove
this Alert when the Host was fenced manually failed and a junk Alert
remained in the database.

This patch sets the Host id on the Alert log message.

Change-Id: Iee997e6b3df37f411a74815757195dc584c4e8e5
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1045139
Signed-off-by: Eli Mesika <emes...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/22911/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
index e931ed5..61a24de 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
@@ -553,6 +553,7 @@
             AuditLogableBase auditLogable = new AuditLogableBase();
             auditLogable.addCustomValue("Host", vdsName);
             auditLogable.addCustomValue("Status", actionName);
+            auditLogable.setVdsId(getVds().getId());
             AuditLogDirector.log(auditLogable, 
AuditLogType.VDS_ALERT_FENCE_STATUS_VERIFICATION_FAILED);
             log.errorFormat("Failed to verify host {0} {1} status. Have 
retried {2} times with delay of {3} seconds between each retry.",
                     vdsName,


-- 
To view, visit http://gerrit.ovirt.org/22911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee997e6b3df37f411a74815757195dc584c4e8e5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to