Fabian Deutsch has posted comments on this change.
Change subject: [RFE] Use Management class to pass informations
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
....................................................
File src/engine_page.py
Line 348: self.logger.info("Starting vdsm-reg service")
Line 349: deployUtil._logExec([constants.EXT_SERVICE, 'vdsm-reg',
'start'])
Line 350:
Line 351: mgmt = Management()
Line 352: mgmt.update("oVirt Engine http://%s:%s"; % (cfg["server"],
We need to ensure that this line does not get to long.
At least we need to test how it looks on screen.
Line 353: cfg["port"),
Line 354: ["ovirtmgmt"], # FIXME is this still created?
Line 355: None)
Line 356:
Line 350:
Line 351: mgmt = Management()
Line 352: mgmt.update("oVirt Engine http://%s:%s"; % (cfg["server"],
Line 353: cfg["port"),
Line 354: ["ovirtmgmt"], # FIXME is this still created?
is ovirtmgmt still created? or called differently? can this change?
can we use a functioncall to determine this?
Line 355: None)
Line 356:
Line 357: msgConf = "{engine_name} Configuration Successfully " \
Line 358: " Updated".format(
--
To view, visit http://gerrit.ovirt.org/22375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I441375ea4f7e18b55a7e4d8a7f661e067598de30
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabi...@fedoraproject.org>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
