[Engine-patches] Change in ovirt-engine[master]: engine: Extract getNetwork() method

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: engine: Extract getNetwork() method
......................................................................

engine: Extract getNetwork() method

To many repetitions of getParameters().getNetwork()

Change-Id: I7c6257df48afa86673eda39499c53d7f09325365
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/70/22770/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
index 102b0f0..0350be6 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java
@@ -33,7 +33,7 @@
 
             @Override
             public Void runInTransaction() {
-                getNetworkClusterDAO().remove(getParameters().getVdsGroupId(), 
getParameters().getNetwork().getId());
+                getNetworkClusterDAO().remove(getParameters().getVdsGroupId(), 
getNetwork().getId());
                 return null;
             }
         });
@@ -44,7 +44,7 @@
     @Override
     protected boolean canDoAction() {
         DetachNetworkValidator validator =
-                new DetachNetworkValidator(getParameters().getNetwork(), 
getParameters().getNetworkCluster());
+                new DetachNetworkValidator(getNetwork(), 
getParameters().getNetworkCluster());
         return validate(validator.notManagementNetwork())
                 && validate(validator.clusterNetworkNotUsedByVms())
                 && validate(validator.clusterNetworkNotUsedByTemplates());
@@ -57,7 +57,7 @@
     }
 
     public String getNetworkName() {
-        return getParameters().getNetwork().getName();
+        return getNetwork().getName();
     }
 
     @Override
@@ -68,12 +68,16 @@
 
     @Override
     public List<PermissionSubject> getPermissionCheckSubjects() {
-        Guid networkId = getParameters().getNetwork() == null ? null : 
getParameters().getNetwork().getId();
+        Guid networkId = getNetwork() == null ? null : getNetwork().getId();
         return Collections.singletonList(new PermissionSubject(networkId,
                 VdcObjectType.Network,
                 getActionType().getActionGroup()));
     }
 
+    private Network getNetwork() {
+        return getParameters().getNetwork();
+    }
+
     private class DetachNetworkValidator extends NetworkValidator {
 
         private NetworkCluster networkCluster;


-- 
To view, visit http://gerrit.ovirt.org/22770
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c6257df48afa86673eda39499c53d7f09325365
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches