Leonardo Bianconi has posted comments on this change.
Change subject: userportal, webadmin: Prevent snapshot in ppc64
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java
Line 68:
Line 69: for (Version version : Version.ALL) {
Line 70: boolean isSnapshotSupported = true;
Line 71:
Line 72: if (!arch.equals(ArchitectureType.undefined)) {
The logic was changed and there is no need to avoid undefined anymore.
Line 73: isSnapshotSupported =
Line 74: ArchStrategyFactory.getStrategy(arch)
Line 75: .run(new
IsSnapshotSupported(version))
Line 76: .returnValue();
Line 83: snapshotMap.put(arch, snapshotArchMap);
Line 84: }
Line 85:
Line 86: return snapshotMap;
Line 87: }
Done
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java
Line 112:
Line 113:
getTable().ensureColumnPresent(SnapshotsViewColumns.statusColumn,
Line 114: constants.statusSnapshot(), true, "75px");
//$NON-NLS-1$
Line 115:
Line 116: boolean archSnapshotSupported =
AsyncDataProvider.isSnapshotSupported(vm.getClusterArch(),
vm.getVdsGroupCompatibilityVersion());
Done
Line 117: boolean memorySnapshotSupported =
Line 118: ((Boolean)
AsyncDataProvider.getConfigValuePreConverted(
Line 119: ConfigurationValues.MemorySnapshotSupported,
Line 120:
vm.getVdsGroupCompatibilityVersion().toString())) && archSnapshotSupported;
--
To view, visit http://gerrit.ovirt.org/21658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I148f0a9356086b31e66d4f5dd6eab6afc642cada
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
