Roy Golan has posted comments on this change.

Change subject: core: adding support for version 3.4
......................................................................


Patch Set 3:

(1 comment)

....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 789: select fn_db_delete_config_value('ENMailPort','general');
Line 790: select 
fn_db_delete_config_value('ENMailUseDefaultCredentials','general');
Line 791: select fn_db_delete_config_value('ENMailUser','general');
Line 792: select fn_db_delete_config_value('FreeSpaceCriticalLow','general');
Line 793: select 
fn_db_delete_config_value('HotPlugUnsupportedOsList','general');
pls check, I think both HotPlugUnsupportedOsList and HotPlugSupportedOsList can 
be removed . currently you renamed the one to be removed :)
Line 794: select 
fn_db_delete_config_value('ImagesSyncronizationTimeout','general');
Line 795: select fn_db_delete_config_value('keystorePass','general');
Line 796: select fn_db_delete_config_value('keystoreUrl','general');
Line 797: select fn_db_delete_config_value('LdapServers','3.0');


-- 
To view, visit http://gerrit.ovirt.org/22672
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e26d21f0c3696017f3e70ba10079a06872a8442
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to