Roy Golan has posted comments on this change.
Change subject: core: adding support for version 3.4
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
Line 56: put(Version.v3_0, new V2FormatTypeMapper());
Line 57: put(Version.v3_1, new
ConstantStorageFormatTypeMapper(StorageFormatType.V3));
Line 58: put(Version.v3_2, new
ConstantStorageFormatTypeMapper(StorageFormatType.V3));
Line 59: put(Version.v3_3, new
ConstantStorageFormatTypeMapper(StorageFormatType.V3));
Line 60: put(Version.v3_4, new
ConstantStorageFormatTypeMapper(StorageFormatType.V3));
VErsion needs to be an enum. will send a patch above yours
Line 61: }
Line 62: };
Line 63:
Line 64: public static StorageFormatType getPreferredForVersion(Version v,
StorageType type) {
....................................................
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 71: select
fn_db_add_config_value('ClusterEmulatedMachines','rhel6.2.0,pc-1.0','3.0');
Line 72: select
fn_db_add_config_value('ClusterEmulatedMachines','rhel6.3.0,pc-1.0','3.1');
Line 73: select
fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0','3.2');
Line 74: select
fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.3');
Line 75: select
fn_db_add_config_value('ClusterEmulatedMachines','rhel6.4.0,pc-1.0,pseries','3.4');
this should be rhel6.5.0 - need to verify RHEL 6.5 will really see light with
3.4
Line 76: select
fn_db_add_config_value('CpuOverCommitDurationMinutes','2','general');
Line 77: --Handling Data directory for ENGINE
Line 78: select fn_db_add_config_value('DataDir','/usr/share/engine','general');
Line 79: select fn_db_add_config_value('DBEngine','Postgres','general');
Line 89: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.0');
Line 90: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.1');
Line 91: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.2');
Line 92: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.3');
Line 93: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.4');
this can be ommited. OSinfo is now talking care of all of that/.
actually all this config value can go down the sink hole... :)
Line 94: select
fn_db_add_config_value('DisableFenceAtStartupInSec','300','general');
Line 95: select fn_db_add_config_value('DirectLUNDiskEnabled','false','3.0');
Line 96: --Handling NetBIOS Domain Name
Line 97: select fn_db_add_config_value('DomainName','example.com','general');
Line 519: select
fn_db_add_config_value('VM64BitMaxMemorySizeInMB','524288','3.0');
Line 520: select
fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.1');
Line 521: select
fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.2');
Line 522: select
fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.3');
Line 523: select
fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.4');
also moved to osinfo. pls ommit
Line 524: select fn_db_add_config_value('VmGracefulShutdownMessage','System
Administrator has initiated shutdown of this Virtual Machine. Virtual Machine
is shutting down.','general');
Line 525: select
fn_db_add_config_value('VmGracefulShutdownTimeout','30','general');
Line 526: select fn_db_add_config_value('VMMinMemorySizeInMB','256','general');
Line 527: --Number of subsequent failures in VM creation in a pool before
giving up and stop creating new VMs
--
To view, visit http://gerrit.ovirt.org/22672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e26d21f0c3696017f3e70ba10079a06872a8442
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
