Moti Asayag has posted comments on this change.

Change subject: core: Support removing external networks
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
Line 30: 
Line 31:     protected void removeVnicProfiles() {
Line 32:         List<VnicProfile> profiles = 
getVnicProfileDao().getAllForNetwork(getNetwork().getId());
Line 33:         for (VnicProfile vnicProfile : profiles) {
Line 34:             getCompensationContext().snapshotEntity(vnicProfile);
is it required in the context of UpdateNetworkCommand ?
Line 35:             getVnicProfileDao().remove(vnicProfile.getId());
Line 36:         }
Line 37:     }
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/22613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I123076564188945753f62c445e684d9f1901e1df
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to