Mike Kolesnik has posted comments on this change.
Change subject: core: Support removing external networks
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkModification.java
Line 5:
Line 6: public abstract class NetworkModification<T extends
AddNetworkStoragePoolParameters> extends NetworkCommon<T> {
Line 7: public NetworkModification(T parameters) {
Line 8: super(parameters);
Line 9: this.setStoragePoolId(getNetwork().getDataCenterId());
Done
Line 10: }
Line 11:
Line 12: @Override
Line 13: protected Network getNetwork() {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java
Line 38: @Override
Line 39: protected void executeCommand() {
Line 40: setStoragePoolId(getNetwork().getDataCenterId());
Line 41: if
(Boolean.TRUE.equals(getParameters().getRemoveFromNetworkProvider()) &&
getNetwork().isExternal()) {
Line 42: removeExternalNetwork();
Yes but I changed the order and made the transaction no dependant on it.
I would still like the network to remain in case of failure to remove it from
the provider, if that was the request of the caller (otherwise he can just ask
to remove the network form oVirt only and achieve independence).
Line 43: }
Line 44:
Line 45: removeVnicProfiles();
Line 46: getNetworkDAO().remove(getNetwork().getId());
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java
Line 9:
Line 10: @NotNull
Line 11: private Guid id;
Line 12:
Line 13: private Boolean removeFromNetworkProvider;
Done
Line 14:
Line 15: public RemoveNetworkParameters() {
Line 16: }
Line 17:
--
To view, visit http://gerrit.ovirt.org/22613
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I123076564188945753f62c445e684d9f1901e1df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
