Alissa Bonas has uploaded a new change for review.
Change subject: ui: rename members to start with lowercase
......................................................................
ui: rename members to start with lowercase
Rename members in several classes to start with lowercase.
Resolves findbugs warnings
Change-Id: I9675f2ca2f9ad5a0b2c57d70870b2a8fe8c86a17
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/32/22732/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
index a7ed056..4ab76e4 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java
@@ -346,7 +346,7 @@
{
super.eventRaised(ev, sender, args);
- if (ev.matchesDefinition(TagModel.SelectionChangedEventDefinition))
+ if (ev.matchesDefinition(TagModel.selectionChangedEventDefinition))
{
onTagSelectionChanged(sender, args);
}
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java
index 3245111..36cbcb9 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagModel.java
@@ -18,7 +18,7 @@
public class TagModel extends Model implements TreeNodeInfo {
- public static EventDefinition SelectionChangedEventDefinition;
+ public static EventDefinition selectionChangedEventDefinition;
private Event privateSelectionChangedEvent;
public Event getSelectionChangedEvent()
@@ -178,12 +178,12 @@
static
{
- SelectionChangedEventDefinition = new
EventDefinition("SelectionChanged", TagModel.class); //$NON-NLS-1$
+ selectionChangedEventDefinition = new
EventDefinition("SelectionChanged", TagModel.class); //$NON-NLS-1$
}
public TagModel()
{
- setSelectionChangedEvent(new Event(SelectionChangedEventDefinition));
+ setSelectionChangedEvent(new Event(selectionChangedEventDefinition));
setName(new EntityModel());
setDescription(new EntityModel());
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
index e78978d..f33d81e 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
@@ -41,7 +41,7 @@
return EJECT_LABEL;
}
- public static EventDefinition ErrorEventDefinition;
+ public static EventDefinition errorEventDefinition;
private Event privateErrorEvent;
public Event getErrorEvent()
@@ -116,14 +116,14 @@
static
{
- ErrorEventDefinition = new EventDefinition("Error",
ConsoleModel.class); //$NON-NLS-1$
+ errorEventDefinition = new EventDefinition("Error",
ConsoleModel.class); //$NON-NLS-1$
}
protected ConsoleModel(VM myVm, Model parentModel) {
this.parentModel = parentModel;
setEntity(myVm);
- setErrorEvent(new Event(ErrorEventDefinition));
+ setErrorEvent(new Event(errorEventDefinition));
setConnectCommand(new UICommand("Connect", this)); //$NON-NLS-1$
}
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
index c32c27e..76f08b5 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java
@@ -27,7 +27,7 @@
@Override
public void eventRaised(Event ev, Object sender, EventArgs args) {
- if (ev.matchesDefinition(ConsoleModel.ErrorEventDefinition)
+ if (ev.matchesDefinition(ConsoleModel.errorEventDefinition)
&& ((sender instanceof SpiceConsoleModel) || (sender
instanceof RdpConsoleModel))) {
consoleModelError(sender, getConsoleModelErrorMessage(sender,
(ErrorCodeEventArgs) args));
}
--
To view, visit http://gerrit.ovirt.org/22732
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9675f2ca2f9ad5a0b2c57d70870b2a8fe8c86a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
