mooli tayer has posted comments on this change. Change subject: tools: Adds validate only argument to notifier ......................................................................
Patch Set 1: (2 comments) Can you explain shortly why we need 'validate'. .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java Line 29: Line 30: /** Line 31: * Command line argument, that tells Notifier to validate properties only (it exits after validation) Line 32: */ Line 33: private static final String ARG_VALIDATE = "validate"; maybe validateOnly? (since we do validation anyway) Line 34: Line 35: /** Line 36: * Initializes logging configuration Line 37: */ Line 49: } Line 50: Line 51: /** Line 52: * @param args Line 53: * [0] configuration file absolute path Is this still relevant? seems that now args[0] is the new validate param. Line 54: */ Line 55: public static void main(String[] args) { Line 56: NotificationProperties prop = null; Line 57: initLogging(); -- To view, visit http://gerrit.ovirt.org/22628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d95f2f4225652d47732c12e5e0716b7f625bbe3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches