Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: List unreverted changes on cleanup
......................................................................
Patch Set 2:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 114: (
Line 115: 'The following lines were not found in {file} and
so '
Line 116: 'were not removed:\n{lines}'
Line 117: ).format(
Line 118: file=filename,
is the following '\n' working? or do you have a single line in the logs?
Line 119: lines='\n'.join(
Line 120: [
Line 121: '\t{line}'.format(line=line)
Line 122: for line in remove_unremoved
Line 129: (
Line 130: 'The following lines were not found in {file} and
so '
Line 131: 'were not reverted to their old content:\n{lines}'
Line 132: ).format(
Line 133: file=filename,
same here
Line 134: lines='\n'.join(
Line 135: [
Line 136: '\tnew:\t{new}\n\told:\t{old}\n'.format(
Line 137: new=new,
--
To view, visit http://gerrit.ovirt.org/22621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9555c6d6a2f1652edc1065f9c49154123e8accc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
