Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: List unreverted changes on cleanup ......................................................................
Patch Set 1: > Do we really need to output it? can't we just save them in one file and > output the path of that file? I don't really mind. I think outputing is simpler, and if there were not many manual changes will also not make output too big. If you want a file that's ok with me too. Where? /tmp? ORIG_FILE.some_extension? /var/log/ovirt-engine? Same format as current change? I also do not really mind just adding that as self.logger.debug, and just warn the user that there were such changes - if they care they can look at the log. I do think we should warn, that's the point of this change. -- To view, visit http://gerrit.ovirt.org/22621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9555c6d6a2f1652edc1065f9c49154123e8accc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
