Alon Bar-Lev has posted comments on this change. Change subject: tools: Adds support to notify systemd using sd_notify ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py Line 97: dest='notify', Line 98: action='store_true', Line 99: default=False, Line 100: help=_('Enables notification of daemon startup success/error'), Line 101: ) I don't care about the bug. any change in services should be synced to all... no reason to do this one by one when mechanism is generic. Line 102: Line 103: def daemonSetup(self): Line 104: if os.geteuid() == 0: Line 105: raise RuntimeError( -- To view, visit http://gerrit.ovirt.org/22630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie62a4ba5a837bcaf216ace9870e212a7151aa8bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches