Alon Bar-Lev has posted comments on this change.
Change subject: tools: Adds support to notify systemd using sd_notify
......................................................................
Patch Set 1:
(2 comments)
Hi,
I thought we are moving this to someone from integration...
Nice work but:
1. Please use the systemd-notify directly, do not try to reverse engineer the
protocol.
2. Please make this behavior exist when --systemd=notify parameter is
established.
3. Please adjust other services (websocket, engine) to this method.
Thanks!
....................................................
File packaging/pythonlib/ovirt_engine/sdnotify.py
Line 22: from . import util
Line 23:
Line 24:
Line 25: @util.export
Line 26: class Notifier(base.Base):
why not just execute the systemd-notify?
Line 27: """Sends messages to systemd about service startup success or
error"""
Line 28:
Line 29: def __init__(self, socket=None):
Line 30: super(Notifier, self).__init__()
....................................................
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
Line 97: dest='notify',
Line 98: action='store_true',
Line 99: default=False,
Line 100: help=_('Enables notification of daemon startup
success/error'),
Line 101: )
why not add to all services? I prefer --systemd=notify.
Line 102:
Line 103: def daemonSetup(self):
Line 104: if os.geteuid() == 0:
Line 105: raise RuntimeError(
--
To view, visit http://gerrit.ovirt.org/22630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie62a4ba5a837bcaf216ace9870e212a7151aa8bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
