Roy Golan has posted comments on this change.
Change subject: core: better excpetion logging of VdsExceptions
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 78: logException(ex);
Line 79: }
Line 80:
Line 81: private void logException(RuntimeException ex) {
Line 82: log.errorFormat("Command {0} execution failed. Exception:
{1}", this, ExceptionUtils.getMessage(ex));
look at the commit message I've put a live example there.
but for that matter I guess yes the parameters will probably be part of the
toString I guess. but what's the harm?
Line 83: if (log.isDebugEnabled()) {
Line 84: log.debugFormat("Detailed stacktrace:", ex);
Line 85: }
Line 86: }
--
To view, visit http://gerrit.ovirt.org/22513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae20330e5761b844a6725d5e84aaa4d05e3db728
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
