Roy Golan has uploaded a new change for review.
Change subject: core: better excpetion logging of VdsExceptions
......................................................................
core: better excpetion logging of VdsExceptions
host details are missing in case of communication errors.
so instead of this (no host details at all:
ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.GetCapabilitiesVDSCommand]
(DefaultQuartzScheduler_Worker-66) Command GetCapabilitiesVDS execution
failed. Exception: VDSNetworkException: java.net.SocketTimeoutException:
connect timed out
it will look like this:
ERROR
[org.ovirt.engine.core.vdsbroker.vdsbroker.GetCapabilitiesVDSCommand]
(DefaultQuartzScheduler_Worker-15) Command
GetCapabilitiesVDSCommand(HostName = local-bmw, HostId =
4ad3ef8c-ee35-4853-8e49-9637fcef45e1, vds=Host[local-bmw]) execution
failed. Exception: VDSNetworkException: java.net.SocketTimeoutException:
connect timed out
Change-Id: Iae20330e5761b844a6725d5e84aaa4d05e3db728
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/13/22513/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
index afffcbe..6e5aeb9 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
@@ -79,7 +79,7 @@
}
private void logException(RuntimeException ex) {
- log.errorFormat("Command {0} execution failed. Exception: {1}",
getCommandName(), ExceptionUtils.getMessage(ex));
+ log.errorFormat("Command {0} execution failed. Exception: {1}", this,
ExceptionUtils.getMessage(ex));
if (log.isDebugEnabled()) {
log.debugFormat("Detailed stacktrace:", ex);
}
--
To view, visit http://gerrit.ovirt.org/22513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae20330e5761b844a6725d5e84aaa4d05e3db728
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
