Moti Asayag has posted comments on this change.
Change subject: core: scheduling: increase NetworkPolicyUnit performance
......................................................................
Patch Set 2:
(5 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
Line 171: public List<VdsNetworkInterface> getAllInterfacesForCluster(Guid
clusterId) {
Line 172: MapSqlParameterSource parameterSource =
getCustomMapSqlParameterSource()
Line 173: .addValue("cluster_id", clusterId);
Line 174:
Line 175: return
getCallsHandler().executeReadList("GetInterfacesByClusterId",
since the new SP will return host_id, network_name, you can consider it to be
the return type of this DAO: Map<Guid, List<String>>
Or as you suggested - rename it to "getPartialInterfacesForCluter" and also add
a javadoc to its interface to notify this isn't the complete interface.
Line 176: vdsNetworkInterfaceRowMapper,
Line 177: parameterSource);
Line 178: }
Line 179:
....................................................
File packaging/dbscripts/create_views.sql
Line 866: vds_interface_statistics.tx_drop,
vds_interface_statistics.iface_status, vds_interface.type,
vds_interface.gateway,
Line 867: vds_interface.subnet, vds_interface.addr, vds_interface.speed,
vds_interface.vlan_id, vds_interface.bond_type,
Line 868: vds_interface.bond_name, vds_interface.is_bond,
vds_interface.bond_opts, vds_interface.mac_addr,
Line 869: vds_interface.network_name, vds_interface.name,
vds_static.vds_id, vds_static.vds_name, vds_interface.id,
Line 870: vds_interface.boot_protocol, vds_interface.mtu as mtu,
vds_interface.bridged, 1 AS is_vds, vds_static.vds_group_id
if going with the proposed join on network_sp.sql this change can be spared.
Line 871: FROM vds_interface_statistics
Line 872: JOIN vds_interface ON vds_interface_statistics.id = vds_interface.id
Line 873: JOIN vds_static ON vds_interface.vds_id = vds_static.vds_id;
Line 874:
....................................................
File packaging/dbscripts/network_sp.sql
Line 357:
Line 358: END; $procedure$
Line 359: LANGUAGE plpgsql;
Line 360:
Line 361: Create or replace FUNCTION GetInterfacesByClusterId(v_cluster_id UUID)
perhaps should be renamed to GetHostNetworksByCluster
Line 362: RETURNS SETOF vds_interface_view STABLE
Line 363: AS $procedure$
Line 364: BEGIN
Line 365: RETURN QUERY SELECT *
Line 361: Create or replace FUNCTION GetInterfacesByClusterId(v_cluster_id UUID)
Line 362: RETURNS SETOF vds_interface_view STABLE
Line 363: AS $procedure$
Line 364: BEGIN
Line 365: RETURN QUERY SELECT *
only vds_id and network_name are required
Line 366: FROM vds_interface_view
Line 367: WHERE vds_group_id = v_cluster_id;
Line 368: END; $procedure$
Line 369: LANGUAGE plpgsql;
Line 362: RETURNS SETOF vds_interface_view STABLE
Line 363: AS $procedure$
Line 364: BEGIN
Line 365: RETURN QUERY SELECT *
Line 366: FROM vds_interface_view
this view includes the vds_interface_statistics which isn't required for this
select.
It can be reduced to a join between vds_interface (for network_name) and
vds_static (for cluster-id)
Line 367: WHERE vds_group_id = v_cluster_id;
Line 368: END; $procedure$
Line 369: LANGUAGE plpgsql;
Line 370:
--
To view, visit http://gerrit.ovirt.org/22463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b394b5d50abcbf58c63cb2d2af3867197ddb788
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
