Moti Asayag has posted comments on this change.

Change subject: core: scheduling: increase NetworkPolicyUnit performance
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Thanks a lot! 

A minor comment inside.

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java
Line 70: 
Line 71:     /**
Line 72:      * Retrieves all interfaces for the given Cluster id.
Line 73:      *
Line 74:      * @param id
param name should be clusterId
Line 75:      *            the cluster id
Line 76:      * @return the list of interfaces
Line 77:      */
Line 78:     List<VdsNetworkInterface> getAllInterfacesForCluster(Guid 
clusterId);


-- 
To view, visit http://gerrit.ovirt.org/22463
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b394b5d50abcbf58c63cb2d2af3867197ddb788
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to