Shubhendu Tripathi has posted comments on this change.

Change subject: engine: Gluster peer probe and status on same server
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java
Line 27:      * @param clusterId
Line 28:      * @return One of the servers in up status
Line 29:      */
Line 30:     public VDS getRandomUpServer(Guid clusterId) {
Line 31:         List<VDS> servers = getAllUpServers(clusterId);
Bit curious if the list would be randomly ordered always as we are always 
returning the first entry below.
Line 32:         if (servers == null || servers.isEmpty()) {
Line 33:             return null;
Line 34:         }
Line 35:         return servers.get(0);


-- 
To view, visit http://gerrit.ovirt.org/22448
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a0c8f270b70a6afd3fd1490e5bb602d9b03f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to