Sahina Bose has posted comments on this change.

Change subject: engine: Gluster peer probe and status on same server
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 419:                         if (newUpServer == null) {
Line 420:                             //there's no other up server. so there's 
no issue with peer status results
Line 421:                             return true;
Line 422:                         }
Line 423:                         List<GlusterServerInfo> newGlusterServers = 
getGlusterPeers(newUpServer.getId());
Will introduce number of retries and a delay between these.
Regarding status check, since our hostExists logic does not have this now, will 
not introduce it as part of this patch
Line 424:                         if (!hostExists(newGlusterServers, getVds())) 
{
Line 425:                             // try once more?
Line 426:                             customLogValues.put("Command", "gluster 
peer status " + getVds().getHostName());
Line 427:                             
setNonOperational(NonOperationalReason.GLUSTER_COMMAND_FAILED, customLogValues);


-- 
To view, visit http://gerrit.ovirt.org/22448
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a0c8f270b70a6afd3fd1490e5bb602d9b03f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to