Vojtech Szocs has posted comments on this change. Change subject: webadmin: First login loading stuck. ......................................................................
Patch Set 1: OK, here's my summary on this issue (please refer to my inline comments for details, I was talking to myself for a while): * just removing "getTable().setLoadingState(LOADING)" statement seems to fix the issue addressed by this patch * however, I'd suggest to do "modelProvider.refresh()" to trigger force refresh on given model anyway Now I remembered that we added "getTable().setLoadingState(LOADING)" statement to ensure user doesn't see old data when switching to given main tab, which aparently this conflicts with initial startup. In addition to my summary, we could also modify DataBoundTabModelProvider#refresh implementation to do "getTable().setLoadingState(LOADING)" before doing "getModel().getForceRefreshCommand().execute()" - this way, we preserve the original intention to trigger loading animation when switching to main tab, too. @Alex/Gilad, what do you think guys? As for the mystery of multiple VM-related queries, after some debugging, turns out that this is due to how UiCommon code is designed, for example: * all (!) UiCommon models are created (instantiated) right after login * VmListModel constructor triggers GetVmCustomProperties query * there are other, logically unrelated models like ClusterVmListModel which extend VmListModel and therefore trigger same queries The multiple VM-related queries shouldn't be addressed by this patch, as it's something to do with model class design. -- To view, visit http://gerrit.ovirt.org/21389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a6f9e47a5af34b66bd9dc32be55d2775f4b1c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
