Vojtech Szocs has posted comments on this change. Change subject: webadmin: First login loading stuck. ......................................................................
Patch Set 1: (1 comment) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java Line 89: Line 90: getTable().resetScrollPosition(); Line 91: Line 92: // Do a manual refresh. Line 93: modelProvider.onManualRefresh(); Hm, as this is WebAdmin-specific presenter, calling modelProvider#onManualRefresh shouldn't have any real effect, as per no-op implementation in DataBoundTabModelProvider#onManualRefresh method. Am I missing something? Perhaps this should be: modelProvider.refresh(); whose implementation does getModel().getForceRefreshCommand().execute(); I think I'm missing something, will apply & test this patch. Line 94: } Line 95: Line 96: /** Line 97: * Subclasses should fire an event to indicate that the table selection has changed. -- To view, visit http://gerrit.ovirt.org/21389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97a6f9e47a5af34b66bd9dc32be55d2775f4b1c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
