Arik Hadas has posted comments on this change.
Change subject: backend: Avoid IsoPrefix command when no iso attached
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 374:
Line 375: public static String cdPathWindowsToLinux(String windowsPath,
Guid storagePoolId, Guid vdsId) {
Line 376: if (StringUtils.isEmpty(windowsPath)) {
Line 377: return windowsPath; // empty string is used for 'eject'
Line 378: }
I hope this code will be removed soon.. but until then, the
cdPathWindowsToLinux(String, String) method should not be called from other
classes (and currently it doesn't) so how about making it private and remove
this check from there (so that we won't check the same thing twice) ?
Line 379: return cdPathWindowsToLinux(windowsPath, (String)
Backend.getInstance()
Line 380: .getResourceManager()
Line 381: .RunVdsCommand(VDSCommandType.IsoPrefix, new
VdsAndPoolIDVDSParametersBase(vdsId, storagePoolId))
Line 382: .getReturnValue());
--
To view, visit http://gerrit.ovirt.org/22257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
