Martin Betak has uploaded a new change for review.

Change subject: backend: Avoid IsoPrefix command when no iso attached
......................................................................

backend: Avoid IsoPrefix command when no iso attached

Added check to ImagesHandler.cdPathWindowsToLinux to immediately return
when passed empty string and avoid running the IsoPrefixVSDCommand to
the same end result.

Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec
Signed-off-by: Martin Betak <mbe...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/22257/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
index 2400324..dd19bf1 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
@@ -373,6 +373,9 @@
     }
 
     public static String cdPathWindowsToLinux(String windowsPath, Guid 
storagePoolId, Guid vdsId) {
+        if (StringUtils.isEmpty(windowsPath)) {
+            return windowsPath; // empty string is used for 'eject'
+        }
         return cdPathWindowsToLinux(windowsPath, (String) Backend.getInstance()
                 .getResourceManager()
                 .RunVdsCommand(VDSCommandType.IsoPrefix, new 
VdsAndPoolIDVDSParametersBase(vdsId, storagePoolId))


-- 
To view, visit http://gerrit.ovirt.org/22257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to