Martin Sivák has posted comments on this change. Change subject: core: Decrement pending memory/cpus after finished migration ......................................................................
Patch Set 6: Actually clearing the memory before the VM is reported running on the destination host is much worse in my opinion. The solution we have now will prevent you from starting a new VM until the migration is finished for good. That in my opinion is the "right" thing to do. The processVm solution would effectively disable the pending counter, because we would clear the pending value immediately (it is set from SchedulingManager.schedule that is called only couple of lines earlier). The best solution would be to clear the pending value once we start seeing the Vm on the destination host. But we would need proper error checking to decrement everywhere where the process can be interrupted. -- To view, visit http://gerrit.ovirt.org/22233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
