Omer Frenkel has posted comments on this change. Change subject: core: Decrement pending memory/cpus after finished migration ......................................................................
Patch Set 6: although this looks ok, the problem with this solution is that the pending is cleared long after the destination host already report used memory and cpu that includes this vm, so it is taken into account twice, and for large vms (for example 128gb ram) this will probably have bad affect. we could decrease right after (where currently the processVm is called) this might have the other way around where we clear before it is reported, but this should be shorter, i think. best would be to identify the vm is running on dest, and then decrease -- To view, visit http://gerrit.ovirt.org/22233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
