Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Clean up treatment of /etc/exports
......................................................................
Patch Set 6:
(1 comment)
I leave the rest of the discussion for you and sandro.
I think that simplicity and determinism have higher priority over complexity
and non determinism.
All we require is for admin to specify the extra parameters for us and not
update file manually, and I am fine with it, we can put a big fat warning DO
NOT UPDATE THIS FILE MANUALLY USE THIS METHOD TO DO SO.
Complex logic is not something I would like to see nor maintain.
But as you going to maintain this, your call.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py
Line 168: self.logger.debug(
Line 169: '{path} already in {conf}, not changing
it'.format(
Line 170: path=path,
Line 171: conf=self._conf,
Line 172: )
it is, as when you remove or modify debug you do not modify actual program
logic. this pattern is to avoid mistakes of code move / copy paste and such.
Line 173: )
Line 174: else:
Line 175:
self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
Line 176: filetransaction.FileTransaction(
--
To view, visit http://gerrit.ovirt.org/20709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
