Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Clean up treatment of /etc/exports ......................................................................
Patch Set 5: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py Line 128: modifiedList=uninstall_files, Line 129: ) Line 130: ) Line 131: else: Line 132: self._conf = osetupcons.FileLocations.NFS_EXPORT_FILE as this is something you can checkout in setup and it is not changed during the lifecycle better to do it there at initialization, and all other method to keep object state intact. Line 133: if index is None: Line 134: exports_changed = True Line 135: exports_content.append(new_line) Line 136: exports_uninstall_group.addChanges( -- To view, visit http://gerrit.ovirt.org/20709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
