Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin : Hide virt fields in the host->general sub-tab in
Gluster mode
......................................................................
webadmin : Hide virt fields in the host->general sub-tab in Gluster mode
Not adding instead of just hiding virt-related fields in the host -> general
sub-tab and hence fix the allignment issues.
Modified the SubTabHostGeneralView to NOT take row numbers statically,
as doing so,will introduce blank spaces if a particular row is made
invisible in a particular application mode.
So,modified FormBuilder to have a map("nextEmptyRowForColumn") of first unused
rows for each column and hence decide dynamically which row to insert the
current
widget into for a given column.
Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1025101
Signed-off-by: Anmol Babu <anb...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/AbstractFormPanel.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
6 files changed, 107 insertions(+), 43 deletions(-)
Approvals:
anmolbabu: Verified
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
