Vojtech Szocs has posted comments on this change. Change subject: webadmin : Hide virt fields in the host->general sub-tab in Gluster mode ......................................................................
Patch Set 9: I like the new FormItem constructors for better convenience. I think we can merge the patch, assuming it has been verified :-) Two small ideas for improvement (I'll do them in separate patch if they make sense): * when using constructor without row argument, withAutoPlacement() is called by constructor so no need to call it explicitly (SubTabHostGeneralView) * maybe consolidate row + autoPlacementRow into single field (row) -- To view, visit http://gerrit.ovirt.org/22220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
