Kanagaraj M has posted comments on this change.
Change subject: webadmin : Hide virt fields in the host->general sub-tab in
Gluster mode
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java
Line 45: if (isAvailablePropertyName != null) {
Line 46:
getItemsForPropertyName(isAvailablePropertyName).add(item);
Line 47: }
Line 48:
Line 49: return item;
fix indentation
Line 50: }
Line 51:
Line 52: public FormItem addFormItem(int column, FormItem item) {
Line 53: if (item.getIsAvailable()) {
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java
Line 22:
Line 23: private int row;
Line 24: private int column;
Line 25:
Line 26: private String isAvailablePropertyName;
this can be final, as you are not re-intializing
Line 27: private boolean isAvailable = true;
Line 28:
Line 29: private String name;
Line 30: private Widget valueWidget;
--
To view, visit http://gerrit.ovirt.org/22220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
