anmolbabu has posted comments on this change.

Change subject: webadmin : Removing virt-related fields in the host->general 
sub-tab
......................................................................


Patch Set 1:

(4 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-12-10 11:15:37 +0530
Line 4: Commit:     Anmol Babu <anb...@redhat.com>
Line 5: CommitDate: 2013-12-10 11:19:50 +0530
Line 6: 
Line 7: webadmin : Removing instead of hiding virt-related fields in the 
host->general sub-tab
Done
Line 8: 
Line 9: Removing instead of hiding virt-related fields in the host -> general
Line 10: sub-tab and hence fix the allignment issues
Line 11: 


....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormBuilder.java
Line 30:             formPanel.addFormDetailView(numOfRows);
Line 31:         }
Line 32:     }
Line 33: 
Line 34:     Map<Integer, Integer> firstEmptyRowOfColumns;
Done
Line 35: 
Line 36:     /**
Line 37:      * Adds new item to the form panel.
Line 38:      */


Line 60: 
Line 61:     public int getNextRow(int column) {
Line 62:         int curRow;
Line 63:         if(firstEmptyRowOfColumns == null) {
Line 64:             firstEmptyRowOfColumns = new HashMap<Integer, Integer>();
Done
Line 65:         }
Line 66:         if(!firstEmptyRowOfColumns.containsKey(column)) {
Line 67:             firstEmptyRowOfColumns.put(column, 0);
Line 68:         }


....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/FormItem.java
Line 45:     }
Line 46: 
Line 47:     public void setRow(int row) {
Line 48:         this.row = row;
Line 49:     }
Done
Line 50: 
Line 51:     public FormItem(int row, int column) {
Line 52:         this("", new TextBoxLabel(), row, column); //$NON-NLS-1$
Line 53:     }


-- 
To view, visit http://gerrit.ovirt.org/22220
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to