[Engine-patches] Change in ovirt-engine[master]: core: VmValidationUtils - getter for OsRepository

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: core: VmValidationUtils - getter for OsRepository
......................................................................

core: VmValidationUtils - getter for OsRepository

VmValidationUtils -> adding a getter for OsRepository instance
(for convenient usage).

Change-Id: I9ddb17fb0ed5fa76b1d4c64cd32e1ab6ff22a729
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/22217/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
index 1fe71ee..9aa6c5f 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
@@ -32,7 +32,7 @@
      * @return If the OS type is supported.
      */
     public static boolean isOsTypeSupported(int osId, ArchitectureType 
architectureType) {
-        return architectureType == 
(SimpleDependecyInjector.getInstance().get(OsRepository.class).getArchitectureFromOS(osId));
+        return architectureType == 
getOsRepository().getArchitectureFromOS(osId);
     }
 
     /**
@@ -43,7 +43,7 @@
      * @return If the OS type is supported.
      */
     public static boolean isOsSupportedForVirtIoScsi(int osId, Version 
clusterVersion) {
-        ArrayList<String> diskInterfaces = 
SimpleDependecyInjector.getInstance().get(OsRepository.class).getDiskInterfaces(osId,
 clusterVersion);
+        ArrayList<String> diskInterfaces = 
getOsRepository().getDiskInterfaces(osId, clusterVersion);
         return diskInterfaces.contains(DiskInterface.VirtIO_SCSI.toString());
     }
 
@@ -53,7 +53,7 @@
      * @return The minimum VM memory size allowed (as per configuration).
      */
     public static Integer getMinMemorySizeInMb(int osId, Version version) {
-        return 
SimpleDependecyInjector.getInstance().get(OsRepository.class).getMinimumRam(osId,
 version);
+        return getOsRepository().getMinimumRam(osId, version);
     }
 
     /**
@@ -64,6 +64,10 @@
      * @return The maximum VM memory setting for this OS (as per 
configuration).
      */
     public static Integer getMaxMemorySizeInMb(int osId, Version 
clusterVersion) {
-        return 
SimpleDependecyInjector.getInstance().get(OsRepository.class).getMaximumRam(osId,
 clusterVersion);
+        return getOsRepository().getMaximumRam(osId, clusterVersion);
+    }
+
+    private static OsRepository getOsRepository() {
+        return SimpleDependecyInjector.getInstance().get(OsRepository.class);
     }
 }


-- 
To view, visit http://gerrit.ovirt.org/22217
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ddb17fb0ed5fa76b1d4c64cd32e1ab6ff22a729
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches