Gustavo Frederico Temple Pedrosa has uploaded a new change for review.
Change subject: core: [Fix] Check PCI limits when adding NICs
......................................................................
core: [Fix] Check PCI limits when adding NICs
The AddVmInterfaceCommand didn't account for all the existing NICs
while passing the "interfaces" list to the checkPciAndIdeLimits
procedure, so a limitless number of NICs could be created.
This change fix this behaviour (like in the UpdateVmInterfaceCommand).
Change-Id: Ib8594848b576dd5543d0fa77b5471b5dadc6ac4d
Signed-off-by: Gustavo Pedrosa <gustavo.pedr...@eldorado.org.br>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/15/22215/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
index 8f5b89d..7aa8775 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
@@ -1,6 +1,6 @@
package org.ovirt.engine.core.bll.network.vm;
-import java.util.Collections;
+import java.util.ArrayList;
import java.util.List;
import org.apache.commons.lang.StringUtils;
@@ -122,7 +122,10 @@
}
// check that not exceeded PCI and IDE limit
- if (!pciAndIdeWithinLimit(vm, Collections.<VmNic>
singletonList(getInterface()))) {
+ List<VmNic> allInterfaces = new ArrayList<>(interfaces);
+ allInterfaces.add(getInterface());
+
+ if (!pciAndIdeWithinLimit(vm, allInterfaces)) {
return false;
}
--
To view, visit http://gerrit.ovirt.org/22215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8594848b576dd5543d0fa77b5471b5dadc6ac4d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
