Mike Kolesnik has posted comments on this change.
Change subject: engine: Extract method for network sync-ness
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
Line 168: }
Line 169:
Line 170: public static boolean isNetworkInSync(VdsNetworkInterface iface,
Network network) {
Line 171: return (network.getMtu() == 0 || iface.getMtu() ==
network.getMtu())
Line 172: && ObjectUtils.equals(iface.getVlanId(),
network.getVlanId())
This cqan be changed to Objects.equals
Line 173: && iface.isBridged() == network.isVmNetwork();
Line 174: }
Line 175:
Line 176: /**
--
To view, visit http://gerrit.ovirt.org/22049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91668eacbde561ff0392a86c8fc29c35ead6ac9d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
