Mike Kolesnik has posted comments on this change.
Change subject: engine: Introduce ParallelMultipleActionsRunner
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ParallelMultipleActionsRunner.java
Line 14: super(actionType, parameters, isInternal);
Line 15: }
Line 16:
Line 17: @Override
Line 18: protected void runCommands() {
Since the runCommands in the MultipleActionsRunner class is already being
called from within ThreadPoolUtil.execute I think it would be wasting a thread
to run this code inside it, instead perhaps it's better to alter the
runCommands in MultipleActionsRunner to do the ThreadPoolUtil.execute inside it?
Line 19: for (final CommandBase<?> command : getCommands()) {
Line 20: if (command.getReturnValue().getCanDoAction()) {
Line 21: ThreadPoolUtil.execute(new Runnable() {
Line 22:
--
To view, visit http://gerrit.ovirt.org/22048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a381eb9e3e9d26aeba324fe568a16a44ecef80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
