Allon Mureinik has posted comments on this change. Change subject: core: remove unneeded disconnect operation when performing reconstruct ......................................................................
Patch Set 2: Code-Review+1 (1 comment) .................................................... Commit Message Line 5: CommitDate: 2013-12-05 09:07:49 -0500 Line 6: Line 7: core: remove unneeded disconnect operation when performing reconstruct Line 8: Line 9: When performing reconstruct in case that the old master status isn't changed to inactive there is a call to disconnect from it. please add a \n here, this is an awfully long line. Line 10: This operation is wrong, there is no need to disconnect from the current Line 11: master which can only cause issues. Line 12: Line 13: Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c -- To view, visit http://gerrit.ovirt.org/22088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches