Liron Ar has uploaded a new change for review. Change subject: core: remove unneeded disconnect operation when performing reconstruct ......................................................................
core: remove unneeded disconnect operation when performing reconstruct When performing reconstruct in case that it's status isn't changed to inactive there is a call to disconnect from of the old master. This operation is wrong, there is no need to disconnect from the current master which can only cause to issues. Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1016118 Signed-off-by: Liron Aravot <lara...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/22088/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java index 9a154f4..642b6a5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java @@ -220,8 +220,7 @@ private void connectAndRefreshAllUpHosts(final boolean commandSucceeded) { final boolean isPerformConnectOps = !_isLastMaster && commandSucceeded; - final boolean isPerformDisconnect = !getParameters().isInactive(); - if (isPerformConnectOps || isPerformDisconnect) { + if (isPerformConnectOps) { List<Callable<Void>> tasks = new ArrayList<Callable<Void>>(); for (final VDS vds : getAllRunningVdssInPool()) { tasks.add(new Callable<Void>() { @@ -257,12 +256,6 @@ ex.getMessage()); } } - } - // only if we deactivate the storage domain we want to disconnect from it. - if (isPerformDisconnect) { - StorageHelperDirector.getInstance() - .getItem(getStorageDomain().getStorageType()) - .disconnectStorageFromDomainByVdsId(getStorageDomain(), vds.getId()); } } catch (Exception e) { -- To view, visit http://gerrit.ovirt.org/22088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
