Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 20: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 221: # and remove: Line 222: priority=plugin.Stages.PRIORITY_HIGH, Line 223: ) Line 224: def _process_templates(self): Line 225: for manager in self.environment[ managers are filtered earlier, in _filter_invalid_managers. It's never a string, always a list of objects. It's appended to by the various firewall_manager_*.py modules. Perhaps I did not understand you. Line 226: osetupcons.ConfigEnv.FIREWALL_MANAGERS Line 227: ]: Line 228: manager.prepare() Line 229: Line 226: osetupcons.ConfigEnv.FIREWALL_MANAGERS Line 227: ]: Line 228: manager.prepare() Line 229: Line 230: if self._enabled: The prepare loop above always happens, even if not _enabled. It's needed for the examples files. Line 231: next( Line 232: m for m in self._available_managers Line 233: if m.name == self.environment[ Line 234: osetupcons.ConfigEnv.FIREWALL_MANAGER -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
