Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 20: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 221: # and remove: Line 222: priority=plugin.Stages.PRIORITY_HIGH, Line 223: ) Line 224: def _process_templates(self): Line 225: for manager in self.environment[ before this we should resolve the managers out of the environment. I may miss something... but we get from user which manager to use in comma separated, right? so customization should put environment as if user may put, including in MANAGERS. then in validation we should split it again as we may have override in configuration. Line 226: osetupcons.ConfigEnv.FIREWALL_MANAGERS Line 227: ]: Line 228: manager.prepare() Line 229: Line 226: osetupcons.ConfigEnv.FIREWALL_MANAGERS Line 227: ]: Line 228: manager.prepare() Line 229: Line 230: if self._enabled: why you ask if enabled here? my sense implies that if not enabled we should not reach here at all. if we reached here we should be enabled. Line 231: next( Line 232: m for m in self._available_managers Line 233: if m.name == self.environment[ Line 234: osetupcons.ConfigEnv.FIREWALL_MANAGER -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
