Liron Ar has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java
Line 24: final SetVdsStatusVDSCommandParameters parameters =
getParameters();
Line 25:
Line 26: if (_vdsManager != null) {
Line 27:
Line 28: final VDS vds = getVds();
General - seems like there's a bug here -
we should consider the result of resetIrs only on specific cases, like when
moving to maintenance.
on other cases we might fail to issue spm stop but the status should still
change as it was before.
now failure on spm stop will prevent the host status from changing between
anything, which isn't what we tried to change here.
Line 29: if (vds.getSpmStatus() != VdsSpmStatus.None &&
parameters.getStatus() != VDSStatus.Up) {
Line 30: log.infoFormat("VDS {0} is spm and moved from up
calling resetIrs.", vds.getName());
Line 31: // check if this host was spm and reset if do.
Line 32: getVDSReturnValue().setSucceeded(
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
