Liron Ar has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 6:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 131:
Line 132: // find clusters for hosts that should move to maintenance
Line 133: Set<Guid> clusters = new HashSet<>();
Line 134: for (VDS vds : vdssToMaintenance.values()) {
Line 135: clusters.add(vds.getVdsGroupId());
I've meant to have only one loop here:
for (VDS vds : vdssToMaintenance.values()) {
if (!clusters.contains(vds.vds.getVdsGroupId) {
clusters.add(vds.vds.getVdsGroupId)
List<Network> networks =
-----cluster network treathment-------
DbFacade.getInstance().getNetworkDao().getAllForCluster(id);...
}
}
regardless, in case you haven't noticed- i wrote a general review comment
"The fix is incomplete, take a look on SpmStopVdsCommand if there are tasks the
command will still return as true which will lead you to the same situation."
thanks!
Line 136: }
Line 137: // set network to operational / non-operational
Line 138: for (Guid id : clusters) {
Line 139: List<Network> networks =
DbFacade.getInstance().getNetworkDao().getAllForCluster(id);
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
