Yair Zaslavsky has posted comments on this change.
Change subject: core: Add Kerberos authenticator
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/kerberos/KerberosConfiguration.java
Line 12: import org.slf4j.LoggerFactory;
Line 13:
Line 14: /**
Line 15: * This class contains the same information that is usually saved in
the {@code /etc/kerberos.conf} file, and it has the
Line 16: * capability to generate that file.
Why should it have the capability to generate krb5.conf file?
Line 17: */
Line 18: public class KerberosConfiguration {
Line 19: // The log:
Line 20: private static final Logger log =
LoggerFactory.getLogger(KerberosConfiguration.class);
Line 33: public static KerberosConfiguration getInstance() {
Line 34: if (instance == null) {
Line 35: synchronized (KerberosConfiguration.class) {
Line 36: if (instance == null) {
Line 37: instance = new KerberosConfiguration();
Probably so it wont be performed when the class is loaded, but only on demand.
Juan used this all over his patches.
Line 38: }
Line 39: }
Line 40: }
Line 41: return instance;
--
To view, visit http://gerrit.ovirt.org/21030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4004e4a783530767b2f7682be17b3ce1e9a3802
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
