Liran Zelkha has posted comments on this change.
Change subject: core: Add Kerberos authenticator
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/kerberos/KerberosConfiguration.java
Line 101: writeSections(writer, section.getSections(), 1);
Line 102: writer.printf("\n");
Line 103: }
Line 104:
Line 105: private void writeRelations(PrintWriter writer, List<Relation>
relations, int level) throws IOException {
I admit it's a personal preference, but wouldn't using velocity or any other
templating mechanism make this code more readable?
Line 106: for (Relation relation : relations) {
Line 107: String name = relation.getName();
Line 108: for (String value : relation.getValues()) {
Line 109: writeIndent(writer, level);
--
To view, visit http://gerrit.ovirt.org/21030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4004e4a783530767b2f7682be17b3ce1e9a3802
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
